FailedChanges

Summary

  1. nsurl: Correctly return non-IDNA hosts (details)
  2. nsurl: Free host if nomem encountered (details)
  3. idna: Bounds check during encode/decode (details)
  4. test: Add nsurl test to cover idna_{en,de}code() (details)
  5. idna: use memcpy not strncpy (details)
Commit 6cbaf05ba377f407ed73e75a5a7b847f5f74b3e4 by dsilvers
nsurl: Correctly return non-IDNA hosts
Signed-off-by: Daniel Silverstone <dsilvers@digital-scurf.org>
The file was modifiedutils/nsurl/nsurl.c (diff)
Commit ea13f5a0773ec2428f6f3b610199eb25e8629a6e by dsilvers
nsurl: Free host if nomem encountered
Signed-off-by: Daniel Silverstone <dsilvers@digital-scurf.org>
The file was modifiedutils/nsurl/parse.c (diff)
Commit 758cafe4059b253e6c3f14e6eebaa5b2dadb7835 by dsilvers
idna: Bounds check during encode/decode
Detected by some norwegian students who were doing security analysis, we
would overrun buffers in idna_{en,de}code() so this corrects that
problem.
Signed-off-by: Daniel Silverstone <dsilvers@digital-scurf.org>
The file was modifiedutils/idna.c (diff)
Commit c3794ba8aa4bfa0717a2b678b355fa556f81438f by dsilvers
test: Add nsurl test to cover idna_{en,de}code()
This adds regression checks for the security issue recently fixed in
idna_{en,de}code().
Signed-off-by: Daniel Silverstone <dsilvers@digital-scurf.org>
The file was modifiedtest/nsurl.c (diff)
Commit 24579fab5da8edc6c5485543a6436b76c789e6bd by dsilvers
idna: use memcpy not strncpy
Since we know the number of bytes we want to copy, just use memcpy
instead of strncpy - this will be faster and hopefully will warn less on
arm systems.
Signed-off-by: Daniel Silverstone <dsilvers@digital-scurf.org>
The file was modifiedutils/idna.c (diff)